Skip to content

Commit 977af25

Browse files
targosmarco-ippolito
authored andcommitted
build: disable test-asan workflow
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 8c8e368 commit 977af25

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/test-asan.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ permissions:
3838

3939
jobs:
4040
test-asan:
41-
if: github.event.pull_request.draft == false
41+
if: false # Temporarily disabled. References: https://github.com/nodejs/node/pull/52374, https://github.com/nodejs/node/pull/53651#issuecomment-2198510810
4242
runs-on: ubuntu-20.04
4343
env:
4444
CC: sccache clang

0 commit comments

Comments
 (0)