Skip to content

Commit 97d9d55

Browse files
committed
build: build ICU with ICU_NO_USER_DATA_OVERRIDE
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1625036 CVE-ID: 2023-23920 PR-URL: nodejs-private/node-private#374 Reviewed-by: Michael Dawson <midawson@redhat.com>
1 parent 6ac86a4 commit 97d9d55

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

configure.py

+3
Original file line numberDiff line numberDiff line change
@@ -1669,6 +1669,9 @@ def icu_download(path):
16691669
# always set icu_small, node.gyp depends on it being defined.
16701670
o['variables']['icu_small'] = b(False)
16711671

1672+
# prevent data override
1673+
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']
1674+
16721675
with_intl = options.with_intl
16731676
with_icu_source = options.with_icu_source
16741677
have_icu_path = bool(options.with_icu_path)

0 commit comments

Comments
 (0)