Skip to content

Commit 988c714

Browse files
Trottaddaleax
authored andcommitted
tools: improve prerequisites for test-all-suites
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test. PR-URL: #25892 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 699d161 commit 988c714

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ test-all-valgrind: test-build
467467
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind
468468

469469
.PHONY: test-all-suites
470-
test-all-suites: test-build test-js-native-api test-node-api | bench-addons-build ## Run all test suites.
470+
test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites.
471471
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*
472472

473473
CI_NATIVE_SUITES ?= addons js-native-api node-api

0 commit comments

Comments
 (0)