Skip to content

Commit 98d038a

Browse files
Trotttargos
authored andcommitted
doc: simplify COLLABORATOR_GUIDE.md instructions
Remove bulleted list formatting. Only check email/name for new contributors. Change `full name` to `name` and remove italics to avoid incorrect implication that we need a "legal name". PR-URL: #19458 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
1 parent e5bcd8d commit 98d038a

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

COLLABORATOR_GUIDE.md

+4-5
Original file line numberDiff line numberDiff line change
@@ -494,12 +494,11 @@ The TSC should serve as the final arbiter where required.
494494
one](https://github.com/nodejs/node/commit/b636ba8186) if unsure exactly how
495495
to format your commit messages.
496496

497-
Additionally:
497+
Check PRs from new contributors to make sure the person's name and email address
498+
are correct before merging.
498499

499-
* Double check PRs to make sure the person's _full name_ and email
500-
address are correct before merging.
501-
* All commits should be self-contained (meaning every commit should pass all
502-
tests). This makes it much easier when bisecting to find a breaking change.
500+
All commits should be self-contained, meaning every commit should pass all
501+
tests. This makes it much easier when bisecting to find a breaking change.
503502

504503
### Using `git-node`
505504

0 commit comments

Comments
 (0)