Skip to content

Commit 999e7d7

Browse files
rvaggryzokuken
authored andcommitted
gyp,build: consistent shared library location
Ref: nodejs/node-gyp#2233 Ref: nodejs/gyp-next#69 PR-URL: #35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
1 parent be80faa commit 999e7d7

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

test/common/shared-lib-util.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ function addLibraryPath(env) {
1717

1818
env.LD_LIBRARY_PATH =
1919
(env.LD_LIBRARY_PATH ? env.LD_LIBRARY_PATH + path.delimiter : '') +
20-
path.join(kExecPath, 'lib.target');
20+
kExecPath;
2121
// For AIX.
2222
env.LIBPATH =
2323
(env.LIBPATH ? env.LIBPATH + path.delimiter : '') +
24-
path.join(kExecPath, 'lib.target');
24+
kExecPath;
2525
// For Mac OSX.
2626
env.DYLD_LIBRARY_PATH =
2727
(env.DYLD_LIBRARY_PATH ? env.DYLD_LIBRARY_PATH + path.delimiter : '') +
@@ -34,10 +34,8 @@ function addLibraryPath(env) {
3434
function getSharedLibPath() {
3535
if (common.isWindows) {
3636
return path.join(kExecPath, 'node.dll');
37-
} else if (common.isOSX) {
38-
return path.join(kExecPath, `libnode.${kShlibSuffix}`);
3937
}
40-
return path.join(kExecPath, 'lib.target', `libnode.${kShlibSuffix}`);
38+
return path.join(kExecPath, `libnode.${kShlibSuffix}`);
4139
}
4240

4341
// Get the binary path of stack frames.

tools/install.py

-4
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,6 @@ def files(action):
132132
output_file += '.dll'
133133
else:
134134
output_file = 'lib' + output_file + '.' + variables.get('shlib_suffix')
135-
# GYP will output to lib.target except on OS X, this is hardcoded
136-
# in its source - see the _InstallableTargetInstallPath function.
137-
if sys.platform != 'darwin':
138-
output_prefix += 'lib.target/'
139135

140136
if 'false' == variables.get('node_shared'):
141137
action([output_prefix + output_file], 'bin/' + output_file)

0 commit comments

Comments
 (0)