Skip to content

Commit 99a7e25

Browse files
blakehalljasnell
blakehall
authored andcommittedOct 17, 2018
test: fix assert.strictEqual() parameter order in test-path-maklong.js
The argument order in the strictEqual check was in the wrong order. The first argument is now the actual value and the second argument is the expected value. PR-URL: #23587 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 53fb82d commit 99a7e25

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed
 

‎test/parallel/test-path-makelong.js

+12-11
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,18 @@ if (common.isWindows) {
2929
const file = fixtures.path('a.js');
3030
const resolvedFile = path.resolve(file);
3131

32-
assert.strictEqual(`\\\\?\\${resolvedFile}`,
33-
path.toNamespacedPath(file));
34-
assert.strictEqual(`\\\\?\\${resolvedFile}`,
35-
path.toNamespacedPath(`\\\\?\\${file}`));
36-
assert.strictEqual('\\\\?\\UNC\\someserver\\someshare\\somefile',
37-
path.toNamespacedPath(
38-
'\\\\someserver\\someshare\\somefile'));
39-
assert.strictEqual('\\\\?\\UNC\\someserver\\someshare\\somefile', path
40-
.toNamespacedPath('\\\\?\\UNC\\someserver\\someshare\\somefile'));
41-
assert.strictEqual('\\\\.\\pipe\\somepipe',
42-
path.toNamespacedPath('\\\\.\\pipe\\somepipe'));
32+
assert.strictEqual(path.toNamespacedPath(file),
33+
`\\\\?\\${resolvedFile}`);
34+
assert.strictEqual(path.toNamespacedPath(`\\\\?\\${file}`),
35+
`\\\\?\\${resolvedFile}`);
36+
assert.strictEqual(path.toNamespacedPath(
37+
'\\\\someserver\\someshare\\somefile'),
38+
'\\\\?\\UNC\\someserver\\someshare\\somefile');
39+
assert.strictEqual(path.toNamespacedPath(
40+
'\\\\?\\UNC\\someserver\\someshare\\somefile'),
41+
'\\\\?\\UNC\\someserver\\someshare\\somefile');
42+
assert.strictEqual(path.toNamespacedPath('\\\\.\\pipe\\somepipe'),
43+
'\\\\.\\pipe\\somepipe');
4344
}
4445

4546
assert.strictEqual(path.toNamespacedPath(null), null);

0 commit comments

Comments
 (0)
Please sign in to comment.