Skip to content

Commit 9bca620

Browse files
danbevgibfahn
authored andcommitted
src: remove empty comment in node_http2.h
This commit removes an "empty" comment in node_http2.h that I don't think was intentional and as far as I can tell not a doxygen comment or anything like that. This was not picked up by the cpp linter so a suggestion has also been added to the CheckComment function to detect these in the future. PR-URL: #16400 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent f0576c5 commit 9bca620

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/node_http2.h

-1
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,6 @@ class Http2Options {
333333

334334
static const size_t kAllocBufferSize = 64 * 1024;
335335

336-
////
337336
typedef uint32_t(*get_setting)(nghttp2_session* session,
338337
nghttp2_settings_id id);
339338

tools/cpplint.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3021,7 +3021,7 @@ def CheckComment(line, filename, linenum, next_line_start, error):
30213021
# If the comment contains an alphanumeric character, there
30223022
# should be a space somewhere between it and the // unless
30233023
# it's a /// or //! Doxygen comment.
3024-
if (Match(r'//[^ ]*\w', comment) and
3024+
if (Match(r'(?://[^ ]*\w)|(?:////\s*$)', comment) and
30253025
not Match(r'(///|//\!)(\s+|$)', comment)):
30263026
error(filename, linenum, 'whitespace/comments', 4,
30273027
'Should have a space between // and comment')

0 commit comments

Comments
 (0)