Skip to content

Commit 9c831c0

Browse files
tniessentargos
authored andcommitted
src: fix dead code in RandomPrimeTraits
PR-URL: #37083 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 3187845 commit 9c831c0

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/crypto/crypto_random.cc

+2-4
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ Maybe<bool> RandomPrimeTraits::AdditionalConfig(
110110
return Nothing<bool>();
111111
}
112112
ArrayBufferOrViewContents<unsigned char> add(args[offset + 2]);
113-
BN_bin2bn(add.data(), add.size(), params->add.get());
114-
if (!params->add) {
113+
if (BN_bin2bn(add.data(), add.size(), params->add.get()) == nullptr) {
115114
THROW_ERR_INVALID_ARG_VALUE(env, "invalid options.add");
116115
return Nothing<bool>();
117116
}
@@ -124,8 +123,7 @@ Maybe<bool> RandomPrimeTraits::AdditionalConfig(
124123
return Nothing<bool>();
125124
}
126125
ArrayBufferOrViewContents<unsigned char> rem(args[offset + 3]);
127-
BN_bin2bn(rem.data(), rem.size(), params->rem.get());
128-
if (!params->rem) {
126+
if (BN_bin2bn(rem.data(), rem.size(), params->rem.get()) == nullptr) {
129127
THROW_ERR_INVALID_ARG_VALUE(env, "invalid options.rem");
130128
return Nothing<bool>();
131129
}

0 commit comments

Comments
 (0)