Skip to content

Commit 9ee7d9e

Browse files
joyeecheungRafaelGSS
authored andcommitted
bootstrap: fix wasm_web_api external reference registration
The external references were not actually registered. PR-URL: #42903 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent e74a8da commit 9ee7d9e

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

src/node_external_reference.h

+1
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ class ExternalReferenceRegistry {
9090
V(uv) \
9191
V(v8) \
9292
V(zlib) \
93+
V(wasm_web_api) \
9394
V(worker)
9495

9596
#if NODE_HAVE_I18N_SUPPORT

src/node_wasm_web_api.cc

+3
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Local<Function> WasmStreamingObject::Initialize(Environment* env) {
4141

4242
void WasmStreamingObject::RegisterExternalReferences(
4343
ExternalReferenceRegistry* registry) {
44+
registry->Register(New);
4445
registry->Register(Push);
4546
registry->Register(Finish);
4647
registry->Register(Abort);
@@ -198,6 +199,8 @@ void Initialize(Local<Object> target,
198199

199200
void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
200201
registry->Register(SetImplementation);
202+
registry->Register(StartStreamingCompilation);
203+
WasmStreamingObject::RegisterExternalReferences(registry);
201204
}
202205

203206
} // namespace wasm_web_api

0 commit comments

Comments
 (0)