Skip to content

Commit a0bdbc1

Browse files
joyeecheunggibfahn
authored andcommitted
build: run linter before running tests
PR-URL: #16284 Fixes: https://github.com/node/issues/16283 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1 parent ac1774f commit a0bdbc1

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

Makefile

+13-1
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,26 @@ test: all
213213
$(MAKE) build-addons
214214
$(MAKE) build-addons-napi
215215
$(MAKE) doc-only
216+
$(MAKE) lint
216217
$(MAKE) cctest
217218
$(PYTHON) tools/test.py --mode=release -J \
218219
$(CI_ASYNC_HOOKS) \
219220
$(CI_JS_SUITES) \
220221
$(CI_NATIVE_SUITES) \
221222
doctool known_issues
222-
$(MAKE) lint
223223
endif
224224

225+
# For a quick test, does not run linter or build doc
226+
test-only: all
227+
$(MAKE) build-addons
228+
$(MAKE) build-addons-napi
229+
$(MAKE) cctest
230+
$(PYTHON) tools/test.py --mode=release -J \
231+
$(CI_ASYNC_HOOKS) \
232+
$(CI_JS_SUITES) \
233+
$(CI_NATIVE_SUITES) \
234+
known_issues
235+
225236
test-cov: all
226237
$(MAKE) build-addons
227238
$(MAKE) build-addons-napi
@@ -1107,6 +1118,7 @@ endif
11071118
test-gc \
11081119
test-gc-clean \
11091120
test-hash-seed \
1121+
test-only \
11101122
test-v8 \
11111123
test-v8-all \
11121124
test-v8-benchmarks \

0 commit comments

Comments
 (0)