Skip to content

Commit a33a497

Browse files
authored
doc: cast GetInternalField() return type to v8::Value in addons.md
For the breaking change in https://chromium-review.googlesource.com/c/v8/v8/+/4707972 PR-URL: #49439 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent c9019cc commit a33a497

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

doc/api/addons.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -912,7 +912,8 @@ void MyObject::New(const FunctionCallbackInfo<Value>& args) {
912912
const int argc = 1;
913913
Local<Value> argv[argc] = { args[0] };
914914
Local<Function> cons =
915-
args.Data().As<Object>()->GetInternalField(0).As<Function>();
915+
args.Data().As<Object>()->GetInternalField(0)
916+
.As<Value>().As<Function>();
916917
Local<Object> result =
917918
cons->NewInstance(context, argc, argv).ToLocalChecked();
918919
args.GetReturnValue().Set(result);

0 commit comments

Comments
 (0)