Skip to content

Commit a350d8b

Browse files
committed
deps: V8: cherry-pick 53e62af
Original commit message: [build] Include string in v8.h Explicitly #include<string> in v8.h, since std::string is referenced in it. In the C++ STL shipped with Visual Studio 2019, none of the headers included in v8.h ends up including the C++ string header, which caused a compile error. Bug: v8:9793 Change-Id: I84a133dd10dd6dcc7b70287af393e82cf0dc97df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834321 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#64074} Refs: v8/v8@53e62af PR-URL: #29898 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host>
1 parent 6b962dd commit a350d8b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
# Reset this number to 0 on major V8 upgrades.
4141
# Increment by one for each non-official patch applied to deps/v8.
42-
'v8_embedder_string': '-node.13',
42+
'v8_embedder_string': '-node.14',
4343

4444
##### V8 defaults for Node.js #####
4545

deps/v8/include/v8.h

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include <stdint.h>
2020
#include <stdio.h>
2121
#include <memory>
22+
#include <string>
2223
#include <type_traits>
2324
#include <utility>
2425
#include <vector>

0 commit comments

Comments
 (0)