Skip to content

Commit a423344

Browse files
huseyinacacak-janeatargos
authored andcommitted
build: avoid compiling with VS v17.10
Refs: nodejs/build#3739 PR-URL: #53863 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent 17dba31 commit a423344

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

vcbuild.bat

+8
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,14 @@ goto exit
281281

282282
:msbuild-found
283283

284+
@rem Visual Studio v17.10 has a bug that causes the build to fail.
285+
@rem Check if the version is v17.10 and exit if it is.
286+
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
287+
if %errorlevel% neq 1 (
288+
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
289+
goto exit
290+
)
291+
284292
@rem check if the clang-cl build is requested
285293
if not defined clang_cl goto clang-skip
286294
@rem x64 is hard coded as it is used for both cross and native compilation.

0 commit comments

Comments
 (0)