Skip to content

Commit a569ae4

Browse files
rishabhptrtargos
authored andcommitted
test: remove third argument from assert.strictEqual()
In file test/parallel/test-stream-transform-final.js the ten calls to assert.strictEqual() use a string literal as third argument. When a AssertionError occurs, it reports the string literal and not the first two arguments, so the third agrument is removed and made a comment just above the call to assert.strictEqual(). PR-URL: #22051 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 168abb5 commit a569ae4

File tree

1 file changed

+20
-10
lines changed

1 file changed

+20
-10
lines changed

test/parallel/test-stream-transform-final.js

+20-10
Original file line numberDiff line numberDiff line change
@@ -59,44 +59,54 @@ The order things are called
5959
const t = new stream.Transform({
6060
objectMode: true,
6161
transform: common.mustCall(function(chunk, _, next) {
62-
assert.strictEqual(++state, chunk, 'transformCallback part 1');
62+
// transformCallback part 1
63+
assert.strictEqual(++state, chunk);
6364
this.push(state);
64-
assert.strictEqual(++state, chunk + 2, 'transformCallback part 2');
65+
// transformCallback part 2
66+
assert.strictEqual(++state, chunk + 2);
6567
process.nextTick(next);
6668
}, 3),
6769
final: common.mustCall(function(done) {
6870
state++;
69-
assert.strictEqual(state, 10, 'finalCallback part 1');
71+
// finalCallback part 1
72+
assert.strictEqual(state, 10);
7073
setTimeout(function() {
7174
state++;
72-
assert.strictEqual(state, 11, 'finalCallback part 2');
75+
// finalCallback part 2
76+
assert.strictEqual(state, 11);
7377
done();
7478
}, 100);
7579
}, 1),
7680
flush: common.mustCall(function(done) {
7781
state++;
78-
assert.strictEqual(state, 12, 'flushCallback part 1');
82+
// flushCallback part 1
83+
assert.strictEqual(state, 12);
7984
process.nextTick(function() {
8085
state++;
81-
assert.strictEqual(state, 15, 'flushCallback part 2');
86+
// flushCallback part 2
87+
assert.strictEqual(state, 15);
8288
done();
8389
});
8490
}, 1)
8591
});
8692
t.on('finish', common.mustCall(function() {
8793
state++;
88-
assert.strictEqual(state, 13, 'finishListener');
94+
// finishListener
95+
assert.strictEqual(state, 13);
8996
}, 1));
9097
t.on('end', common.mustCall(function() {
9198
state++;
92-
assert.strictEqual(state, 16, 'end event');
99+
// end event
100+
assert.strictEqual(state, 16);
93101
}, 1));
94102
t.on('data', common.mustCall(function(d) {
95-
assert.strictEqual(++state, d + 1, 'dataListener');
103+
// dataListener
104+
assert.strictEqual(++state, d + 1);
96105
}, 3));
97106
t.write(1);
98107
t.write(4);
99108
t.end(7, common.mustCall(function() {
100109
state++;
101-
assert.strictEqual(state, 14, 'endMethodCallback');
110+
// endMethodCallback
111+
assert.strictEqual(state, 14);
102112
}, 1));

0 commit comments

Comments
 (0)