Skip to content

Commit a60a960

Browse files
targosrichardlau
authored andcommitted
deps: V8: cherry-pick 895949419186
Original commit message: Add -Wno-string-concatenation to test/cctest:cctest_sources v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation. Bug: chromium:1114873 Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69625} Refs: v8/v8@8959494 PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 7fdd6ec commit a60a960

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.71',
39+
'v8_embedder_string': '-node.72',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/test/cctest/BUILD.gn

+7
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,12 @@ v8_header_set("cctest_headers") {
6060
sources = [ "cctest.h" ]
6161
}
6262

63+
config("cctest_sources_config") {
64+
if (is_clang) {
65+
cflags = [ "-Wno-string-concatenation" ]
66+
}
67+
}
68+
6369
v8_source_set("cctest_sources") {
6470
testonly = true
6571

@@ -398,6 +404,7 @@ v8_source_set("cctest_sources") {
398404
"../..:external_config",
399405
"../..:internal_config_base",
400406
"../..:v8_tracing_config",
407+
":cctest_sources_config",
401408
]
402409

403410
public_deps = [

0 commit comments

Comments
 (0)