Skip to content

Commit a7350b3

Browse files
MylesBorinsdanielleadams
authored andcommitted
tools: don't print gold linker warning w/o flag
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 1f27214 commit a7350b3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

configure.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1761,7 +1761,8 @@ def configure_section_file(o):
17611761
proc = subprocess.Popen(['ld.gold'] + ['-v'], stdin = subprocess.PIPE,
17621762
stdout = subprocess.PIPE, stderr = subprocess.PIPE)
17631763
except OSError:
1764-
warn('''No acceptable ld.gold linker found!''')
1764+
if options.node_section_ordering_info != "":
1765+
warn('''No acceptable ld.gold linker found!''')
17651766
return 0
17661767

17671768
match = re.match(r"^GNU gold.*([0-9]+)\.([0-9]+)$",

0 commit comments

Comments
 (0)