Skip to content

Commit ab5dbf9

Browse files
richardlauBethGriggs
authored andcommitted
build: only emit download ICU warnings once
The check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: #26860 PR-URL: #27031 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
1 parent a232cd6 commit ab5dbf9

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

configure.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1311,13 +1311,14 @@ def icu_download(path):
13111311
if not os.access(options.download_path, os.W_OK):
13121312
error('''Cannot write to desired download path.
13131313
Either create it or verify permissions.''')
1314+
attemptdownload = nodedownload.candownload(auto_downloads, "icu")
13141315
for icu in icus:
13151316
url = icu['url']
13161317
md5 = icu['md5']
13171318
local = url.split('/')[-1]
13181319
targetfile = os.path.join(options.download_path, local)
13191320
if not os.path.isfile(targetfile):
1320-
if nodedownload.candownload(auto_downloads, "icu"):
1321+
if attemptdownload:
13211322
nodedownload.retrievefile(url, targetfile)
13221323
else:
13231324
print('Re-using existing %s' % targetfile)

0 commit comments

Comments
 (0)