Skip to content

Commit ac59dc4

Browse files
committed
http: remove legacy parser
Remove the legacy `http_parser` implementation as a dependency and all code that uses it in favor of llhttp, given that the latter has been the default for all of Node 12 with no outstanding issues. PR-URL: #29589 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent ba3be57 commit ac59dc4

39 files changed

+99
-8657
lines changed

β€ŽLICENSE

-23
Original file line numberDiff line numberDiff line change
@@ -114,29 +114,6 @@ The externally maintained libraries used by Node.js are:
114114
purpose. It is provided "as is" without express or implied warranty.
115115
"""
116116

117-
- HTTP Parser, located at deps/http_parser, is licensed as follows:
118-
"""
119-
Copyright Joyent, Inc. and other Node contributors.
120-
121-
Permission is hereby granted, free of charge, to any person obtaining a copy
122-
of this software and associated documentation files (the "Software"), to
123-
deal in the Software without restriction, including without limitation the
124-
rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
125-
sell copies of the Software, and to permit persons to whom the Software is
126-
furnished to do so, subject to the following conditions:
127-
128-
The above copyright notice and this permission notice shall be included in
129-
all copies or substantial portions of the Software.
130-
131-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
132-
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
133-
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
134-
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
135-
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
136-
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
137-
IN THE SOFTWARE.
138-
"""
139-
140117
- ICU, located at deps/icu-small, is licensed as follows:
141118
"""
142119
COPYRIGHT AND PERMISSION NOTICE (ICU 58 and later)

β€ŽMakefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ test-code-cache: with-code-cache
141141
echo "'test-code-cache' target is a noop"
142142

143143
out/Makefile: config.gypi common.gypi node.gyp \
144-
deps/uv/uv.gyp deps/http_parser/http_parser.gyp deps/zlib/zlib.gyp \
144+
deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \
145145
tools/v8_gypfiles/toolchain.gypi tools/v8_gypfiles/features.gypi \
146146
tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp
147147
$(PYTHON) tools/gyp_node.py -f make

β€Ždeps/http_parser/.gitignore

-30
This file was deleted.

β€Ždeps/http_parser/.mailmap

-8
This file was deleted.

β€Ždeps/http_parser/.travis.yml

-13
This file was deleted.

β€Ždeps/http_parser/AUTHORS

-68
This file was deleted.

β€Ždeps/http_parser/LICENSE-MIT

-19
This file was deleted.

β€Ždeps/http_parser/Makefile

-160
This file was deleted.

0 commit comments

Comments
Β (0)