src: add getValidateFd() to node_file

Author: pluris

lib/internal/fs/sync.js

@@ -89,8 +89,6 @@ function close(fd) {
 }
 
 function fsync(fd) {
-  fd = getValidatedFd(fd);
-
   return binding.fsyncSync(fd);
 }
 

src/node_file.cc

@@ -116,6 +116,24 @@ inline int64_t GetOffset(Local<Value> value) {
   return IsSafeJsInt(value) ? value.As<Integer>()->Value() : -1;
 }
 
+inline int GetValidatedFd(Environment* env, Local<Value> value) {
+  if (!value->IsInt32()) {
+    env->isolate()->ThrowException(ERR_INVALID_ARG_TYPE(
+        env->isolate(), "Invalid argument. The fd must be int32."));
+    return 1 << 30;
+  }
+
+  const int fd = value.As<Int32>()->Value();
+
+  if (fd < 0 || fd > INT32_MAX) {
+    env->isolate()->ThrowException(ERR_OUT_OF_RANGE(
+        env->isolate(), "It must be >= 0 && <= INT32_MAX. Received %d", fd));
+    return 1 << 30;
+  }
+
+  return fd;
+}
+
 static const char* get_fs_func_name_by_type(uv_fs_type req_type) {
   switch (req_type) {
 #define FS_TYPE_TO_NAME(type, name)                                            \
@@ -1647,10 +1665,8 @@ static void FsyncSync(const FunctionCallbackInfo<Value>& args) {
   const int argc = args.Length();
   CHECK_GE(argc, 1);
 
-  CHECK(args[0]->IsInt32());
-
-  const int fd = args[0].As<Int32>()->Value();
-  CHECK_GE(fd, 0);
+  const int fd = GetValidatedFd(env, args[0]);
+  if (fd == (1 << 30)) return;
 
   uv_fs_t req;
   FS_SYNC_TRACE_BEGIN(fsync);