Skip to content

Commit af655f5

Browse files
nbdaaronMylesBorins
authored andcommitted
n-api: change assert ok check to notStrictEqual.
Backport-PR-URL: #19265 PR-URL: #18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 5b1b74c commit af655f5

File tree

1 file changed

+7
-9
lines changed
  • test/addons-napi/test_general

1 file changed

+7
-9
lines changed

test/addons-napi/test_general/test.js

+7-9
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ assert.strictEqual(test_general.testGetPrototype(baseObject),
2828
Object.getPrototypeOf(baseObject));
2929
assert.strictEqual(test_general.testGetPrototype(extendedObject),
3030
Object.getPrototypeOf(extendedObject));
31-
assert.ok(test_general.testGetPrototype(baseObject) !==
32-
test_general.testGetPrototype(extendedObject),
33-
'Prototypes for base and extended should be different');
31+
// Prototypes for base and extended should be different.
32+
assert.notStrictEqual(test_general.testGetPrototype(baseObject),
33+
test_general.testGetPrototype(extendedObject));
3434

3535
// test version management functions
3636
// expected version is currently 1
@@ -70,17 +70,15 @@ assert.strictEqual(test_general.derefItemWasCalled(), true,
7070
// Assert that wrapping twice fails.
7171
const x = {};
7272
test_general.wrap(x);
73-
assert.throws(function() {
74-
test_general.wrap(x);
75-
}, Error);
73+
assert.throws(() => test_general.wrap(x), Error);
7674

7775
// Ensure that wrapping, removing the wrap, and then wrapping again works.
7876
const y = {};
7977
test_general.wrap(y);
8078
test_general.removeWrap(y);
81-
assert.doesNotThrow(function() {
82-
test_general.wrap(y);
83-
}, Error, 'Wrapping twice succeeds if a remove_wrap() separates the instances');
79+
assert.doesNotThrow(() => test_general.wrap(y), Error,
80+
'Wrapping twice succeeds if a remove_wrap()' +
81+
' separates the instances');
8482

8583
// Ensure that removing a wrap and garbage collecting does not fire the
8684
// finalize callback.

0 commit comments

Comments
 (0)