Skip to content

Commit afc5636

Browse files
committedJul 29, 2018
src: rename WorkerThreadMain to PlatformWorkerThread
Refs: #21079 (comment) PR-URL: #21982 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent e3a4702 commit afc5636

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed
 

‎src/node_platform.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ using v8::TracingController;
1717

1818
namespace {
1919

20-
static void WorkerThreadMain(void* data) {
20+
static void PlatformWorkerThread(void* data) {
2121
TRACE_EVENT_METADATA1("__metadata", "thread_name", "name",
22-
"BackgroundTaskRunner");
22+
"PlatformWorkerThread");
2323
TaskQueue<Task>* pending_worker_tasks = static_cast<TaskQueue<Task>*>(data);
2424
while (std::unique_ptr<Task> task = pending_worker_tasks->BlockingPop()) {
2525
task->Run();
@@ -32,7 +32,7 @@ static void WorkerThreadMain(void* data) {
3232
WorkerThreadsTaskRunner::WorkerThreadsTaskRunner(int thread_pool_size) {
3333
for (int i = 0; i < thread_pool_size; i++) {
3434
std::unique_ptr<uv_thread_t> t { new uv_thread_t() };
35-
if (uv_thread_create(t.get(), WorkerThreadMain,
35+
if (uv_thread_create(t.get(), PlatformWorkerThread,
3636
&pending_worker_tasks_) != 0) {
3737
break;
3838
}

‎test/parallel/test-trace-events-metadata.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ proc.once('exit', common.mustCall(() => {
3131
trace.args.name === 'JavaScriptMainThread'));
3232
assert(traces.some((trace) =>
3333
trace.name === 'thread_name' &&
34-
trace.args.name === 'BackgroundTaskRunner'));
34+
trace.args.name === 'PlatformWorkerThread'));
3535
assert(traces.some((trace) =>
3636
trace.name === 'version' &&
3737
trace.args.node === process.versions.node));

0 commit comments

Comments
 (0)