Skip to content

Commit b1e8e0e

Browse files
committed
src: update NODE_MODULE_VERSION to 88
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.6. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent d701247 commit b1e8e0e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

doc/abi_version_registry.json

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"NODE_MODULE_VERSION": [
3+
{ "modules": 88, "runtime": "node", "variant": "v8_8.6", "versions": "15.0.0-pre" },
34
{ "modules": 87, "runtime": "electron", "variant": "electron", "versions": "12" },
45
{ "modules": 86, "runtime": "node", "variant": "v8_8.4", "versions": "15.0.0-pre" },
56
{ "modules": 85, "runtime": "electron", "variant": "electron", "versions": "11" },

src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
* version matching should open a pull request to reserve a number in this
9090
* registry.
9191
*/
92-
#define NODE_MODULE_VERSION 86
92+
#define NODE_MODULE_VERSION 88
9393

9494
// The NAPI_VERSION provided by this version of the runtime. This is the version
9595
// which the Node binary being built supports.

0 commit comments

Comments
 (0)