Skip to content

Commit b1fab88

Browse files
committed
quic: remove unused callback function
PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent 3bae2d5 commit b1fab88

File tree

3 files changed

+0
-11
lines changed

3 files changed

+0
-11
lines changed

lib/internal/quic/core.js

-9
Original file line numberDiff line numberDiff line change
@@ -474,14 +474,6 @@ function onSessionQlog(str) {
474474
}
475475
}
476476

477-
// Called when an error occurs in a QuicSession. When this happens,
478-
// the only remedy is to destroy the session.
479-
function onSessionError(error) {
480-
if (this[owner_symbol]) {
481-
this[owner_symbol].destroy(error);
482-
}
483-
}
484-
485477
// Called by the C++ internals when a client QuicSession receives
486478
// a version negotiation response from the server.
487479
function onSessionVersionNegotiation(
@@ -570,7 +562,6 @@ setCallbacks({
570562
onSessionClientHello,
571563
onSessionClose,
572564
onSessionDestroyed,
573-
onSessionError,
574565
onSessionHandshake,
575566
onSessionKeylog,
576567
onSessionQlog,

src/env.h

-1
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,6 @@ constexpr size_t kFsStatsBufferLength =
455455
V(quic_on_session_client_hello_function, v8::Function) \
456456
V(quic_on_session_close_function, v8::Function) \
457457
V(quic_on_session_destroyed_function, v8::Function) \
458-
V(quic_on_session_error_function, v8::Function) \
459458
V(quic_on_session_handshake_function, v8::Function) \
460459
V(quic_on_session_keylog_function, v8::Function) \
461460
V(quic_on_session_path_validation_function, v8::Function) \

src/quic/node_quic.cc

-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ void QuicSetCallbacks(const FunctionCallbackInfo<Value>& args) {
6060
SETFUNCTION("onSessionClientHello", session_client_hello);
6161
SETFUNCTION("onSessionClose", session_close);
6262
SETFUNCTION("onSessionDestroyed", session_destroyed);
63-
SETFUNCTION("onSessionError", session_error);
6463
SETFUNCTION("onSessionHandshake", session_handshake);
6564
SETFUNCTION("onSessionKeylog", session_keylog);
6665
SETFUNCTION("onSessionUsePreferredAddress", session_use_preferred_address);

0 commit comments

Comments
 (0)