Skip to content

Commit b369ad6

Browse files
dario-piotrowicztargos
authored andcommitted
test: remove unnecessary assert requiring from tests
PR-URL: #57008 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 6951133 commit b369ad6

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

test/node-api/test_uv_threadpool_size/node-options.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const filePath = path.join(__dirname, `./build/${common.buildType}/test_uv_threa
1616
const code = `
1717
const { test } = require(${JSON.stringify(filePath)});
1818
const size = parseInt(process.env.UV_THREADPOOL_SIZE, 10);
19-
require('assert').strictEqual(size, 4);
19+
assert.strictEqual(size, 4);
2020
test(size);
2121
`.trim();
2222
const child = spawnSync(

test/parallel/test-dotenv-edge-cases.js

+10-11
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ const noFinalNewlineSingleQuotesEnvFilePath = '../fixtures/dotenv/no-final-newli
1414
describe('.env supports edge cases', () => {
1515
it('supports multiple declarations, including optional ones', async () => {
1616
const code = `
17-
const assert = require('assert');
1817
assert.strictEqual(process.env.BASIC, 'basic');
1918
assert.strictEqual(process.env.NODE_NO_WARNINGS, '1');
2019
`.trim();
@@ -41,7 +40,7 @@ describe('.env supports edge cases', () => {
4140

4241
it('supports absolute paths', async () => {
4342
const code = `
44-
require('assert').strictEqual(process.env.BASIC, 'basic');
43+
assert.strictEqual(process.env.BASIC, 'basic');
4544
`.trim();
4645
const child = await common.spawnPromisified(
4746
process.execPath,
@@ -53,7 +52,7 @@ describe('.env supports edge cases', () => {
5352

5453
it('supports a space instead of \'=\' for the flag ', async () => {
5554
const code = `
56-
require('assert').strictEqual(process.env.BASIC, 'basic');
55+
assert.strictEqual(process.env.BASIC, 'basic');
5756
`.trim();
5857
const child = await common.spawnPromisified(
5958
process.execPath,
@@ -66,7 +65,7 @@ describe('.env supports edge cases', () => {
6665

6766
it('should handle non-existent .env file', async () => {
6867
const code = `
69-
require('assert').strictEqual(1, 1)
68+
assert.strictEqual(1, 1)
7069
`.trim();
7170
const child = await common.spawnPromisified(
7271
process.execPath,
@@ -79,7 +78,7 @@ describe('.env supports edge cases', () => {
7978

8079
it('should handle non-existent optional .env file', async () => {
8180
const code = `
82-
require('assert').strictEqual(1,1);
81+
assert.strictEqual(1,1);
8382
`.trim();
8483
const child = await common.spawnPromisified(
8584
process.execPath,
@@ -92,8 +91,8 @@ describe('.env supports edge cases', () => {
9291

9392
it('should not override existing environment variables but introduce new vars', async () => {
9493
const code = `
95-
require('assert').strictEqual(process.env.BASIC, 'existing');
96-
require('assert').strictEqual(process.env.AFTER_LINE, 'after_line');
94+
assert.strictEqual(process.env.BASIC, 'existing');
95+
assert.strictEqual(process.env.AFTER_LINE, 'after_line');
9796
`.trim();
9897
const child = await common.spawnPromisified(
9998
process.execPath,
@@ -124,8 +123,8 @@ describe('.env supports edge cases', () => {
124123
// Ref: https://github.com/nodejs/node/issues/52466
125124
const code = `
126125
process.loadEnvFile('./eof-without-value.env');
127-
require('assert').strictEqual(process.env.BASIC, 'value');
128-
require('assert').strictEqual(process.env.EMPTY, '');
126+
assert.strictEqual(process.env.BASIC, 'value');
127+
assert.strictEqual(process.env.EMPTY, '');
129128
`.trim();
130129
const child = await common.spawnPromisified(
131130
process.execPath,
@@ -160,7 +159,7 @@ describe('.env supports edge cases', () => {
160159
const child = await common.spawnPromisified(
161160
process.execPath,
162161
[
163-
'--eval', `require('assert').strictEqual(process.env.BASIC, undefined);`,
162+
'--eval', `assert.strictEqual(process.env.BASIC, undefined);`,
164163
'--', '--env-file', validEnvFilePath,
165164
],
166165
{ cwd: __dirname },
@@ -172,7 +171,7 @@ describe('.env supports edge cases', () => {
172171

173172
it('should handle file without a final newline', async () => {
174173
const code = `
175-
require('assert').strictEqual(process.env.BASIC, 'basic');
174+
assert.strictEqual(process.env.BASIC, 'basic');
176175
`.trim();
177176
const child = await common.spawnPromisified(
178177
process.execPath,

0 commit comments

Comments
 (0)