src: keep PipeWrap::Open function consistent with TCPWrap

theanarkh · juanarbol · commit b454a7665d37 · 2023-01-31T08:04:15.000-05:00
PR-URL: #46064 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/pipe_wrap.cc b/src/pipe_wrap.cc
@@ -217,10 +217,9 @@ void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) {
   if (!args[0]->Int32Value(env->context()).To(&fd)) return;
 
   int err = uv_pipe_open(&wrap->handle_, fd);
-  wrap->set_fd(fd);
+  if (err == 0) wrap->set_fd(fd);
 
-  if (err != 0)
-    env->ThrowUVException(err, "uv_pipe_open");
+  args.GetReturnValue().Set(err);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -217,10 +217,9 @@ void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) {`
`217`	`217`	`if (!args[0]->Int32Value(env->context()).To(&fd)) return;`
`218`	`218`
`219`	`219`	`int err = uv_pipe_open(&wrap->handle_, fd);`
`220`		`- wrap->set_fd(fd);`
	`220`	`+ if (err == 0) wrap->set_fd(fd);`
`221`	`221`
`222`		`- if (err != 0)`
`223`		`- env->ThrowUVException(err, "uv_pipe_open");`
	`222`	`+ args.GetReturnValue().Set(err);`
`224`	`223`	`}`
`225`	`224`
`226`	`225`