Skip to content

Commit b48ca0a

Browse files
BufoViridisMylesBorins
authored andcommitted
src: fix crypto.pbkdf2 callback error argument
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: #18458 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 16f9631 commit b48ca0a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_crypto.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -5421,7 +5421,7 @@ void PBKDF2Request::Work(uv_work_t* work_req) {
54215421

54225422
void PBKDF2Request::After(Local<Value> (*argv)[2]) {
54235423
if (success_) {
5424-
(*argv)[0] = Undefined(env()->isolate());
5424+
(*argv)[0] = Null(env()->isolate());
54255425
(*argv)[1] = Buffer::New(env(), key_, keylen_).ToLocalChecked();
54265426
key_ = nullptr;
54275427
keylen_ = 0;

0 commit comments

Comments
 (0)