Skip to content

Commit baa8231

Browse files
rickyesBethGriggs
authored andcommitted
fs: extract kWriteFileMaxChunkSize constant
PR-URL: #32640 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent a133ac1 commit baa8231

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

lib/internal/fs/promises.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44
// See https://github.com/libuv/libuv/pull/1501.
55
const kIoMaxLength = 2 ** 31 - 1;
66

7+
// Note: This is different from kReadFileBufferLength used for non-promisified
8+
// fs.readFile.
9+
const kReadFileMaxChunkSize = 2 ** 14;
10+
const kWriteFileMaxChunkSize = 2 ** 14;
11+
712
const {
813
MathMax,
914
MathMin,
@@ -150,16 +155,12 @@ async function writeFileHandle(filehandle, data) {
150155
do {
151156
const { bytesWritten } =
152157
await write(filehandle, data, 0,
153-
MathMin(16384, data.length));
158+
MathMin(kWriteFileMaxChunkSize, data.length));
154159
remaining -= bytesWritten;
155160
data = data.slice(bytesWritten);
156161
} while (remaining > 0);
157162
}
158163

159-
// Note: This is different from kReadFileBufferLength used for non-promisified
160-
// fs.readFile.
161-
const kReadFileMaxChunkSize = 16384;
162-
163164
async function readFileHandle(filehandle, options) {
164165
const statFields = await binding.fstat(filehandle.fd, false, kUsePromises);
165166

0 commit comments

Comments
 (0)