Skip to content

Commit bbc455c

Browse files
kvakildanielleadams
authored andcommitted
doc: remind backporter about v8_embedder_string
There's already a reminder earlier in the instructions, but not in the worked example, so it's easy to miss while skimming. PR-URL: #43924 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent 1af7f24 commit bbc455c

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

doc/contributing/maintaining-V8.md

+1
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ Refs: https://github.com/v8/v8/commit/a51f429772d1e796744244128c9feeab4c26a854
270270
PR-URL: https://github.com/nodejs/node/pull/7833
271271
```
272272

273+
* Increase the `v8_embedder_string` number in `common.gypi`.
273274
* Open a PR against the `v6.x-staging` branch in the Node.js repository. Launch
274275
the normal and [V8 CI][] using the Node.js CI system. We only needed to
275276
backport to `v6.x` as the other LTS branches weren't affected by this bug.

0 commit comments

Comments
 (0)