Skip to content

Commit bc755fc

Browse files
danbevBethGriggs
authored andcommitted
src: fix compiler warnings in node_http2.cc
Currently, the following compiler warnings are generated: ../src/node_http2.cc: In static member function ‘static int node::http2::Http2Session::OnStreamClose(nghttp2_session*, int32_t, uint32_t, void*)’: ../src/node_http2.cc:994:16: warning: variable ‘def’ set but not used [-Wunused-but-set-variable] 994 | Local<Value> def = v8::False(env->isolate()); | ^~~ ../src/node_http2.cc: In static member function ‘static void node::http2::Http2Session::Ping( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_http2.cc:2755:16: warning: unused variable ‘env’ [-Wunused-variable] 2755 | Environment* env = Environment::GetCurrent(args); | ^~~ ../src/node_http2.cc: In static member function ‘static void node::http2::Http2Session::Settings( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_http2.cc:2774:16: warning: unused variable ‘env’ [-Wunused-variable] 2774 | Environment* env = Environment::GetCurrent(args); | ^~~ This commit removes these unused variables. PR-URL: #33014 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
1 parent 4c10b5f commit bc755fc

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/node_http2.cc

-3
Original file line numberDiff line numberDiff line change
@@ -991,7 +991,6 @@ int Http2Session::OnStreamClose(nghttp2_session* handle,
991991
MaybeLocal<Value> answer =
992992
stream->MakeCallback(env->http2session_on_stream_close_function(),
993993
1, &arg);
994-
Local<Value> def = v8::False(env->isolate());
995994
if (answer.IsEmpty() || answer.ToLocalChecked()->IsFalse()) {
996995
// Skip to destroy
997996
stream->Destroy();
@@ -2752,7 +2751,6 @@ void Http2Session::Origin(const FunctionCallbackInfo<Value>& args) {
27522751

27532752
// Submits a PING frame to be sent to the connected peer.
27542753
void Http2Session::Ping(const FunctionCallbackInfo<Value>& args) {
2755-
Environment* env = Environment::GetCurrent(args);
27562754
Http2Session* session;
27572755
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
27582756

@@ -2771,7 +2769,6 @@ void Http2Session::Ping(const FunctionCallbackInfo<Value>& args) {
27712769

27722770
// Submits a SETTINGS frame for the Http2Session
27732771
void Http2Session::Settings(const FunctionCallbackInfo<Value>& args) {
2774-
Environment* env = Environment::GetCurrent(args);
27752772
Http2Session* session;
27762773
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
27772774
CHECK(args[0]->IsFunction());

0 commit comments

Comments
 (0)