Skip to content

Commit be80faa

Browse files
committed
tools: update gyp-next to v0.6.0
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 PR-URL: #35635 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
1 parent d5e6495 commit be80faa

File tree

4 files changed

+20
-13
lines changed

4 files changed

+20
-13
lines changed

tools/gyp/.github/workflows/Python_tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
max-parallel: 15
1313
matrix:
1414
os: [macos-latest, ubuntu-latest] # , windows-latest]
15-
python-version: [2.7, 3.6, 3.7, 3.8, 3.9.0-rc.1] # 3.5,
15+
python-version: [2.7, 3.6, 3.7, 3.8, 3.9]
1616
steps:
1717
- uses: actions/checkout@v2
1818
- name: Set up Python ${{ matrix.python-version }}

tools/gyp/CHANGELOG.md

+8-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
66

77
## [Unreleased]
88

9+
## [0.6.0] - 2020-10-13
10+
11+
### Added
12+
- The Makefile generator will now output shared libraries directly to the product
13+
directory on all platforms (previously only macOS).
14+
915
## [0.5.0] - 2020-09-30
1016

1117
### Added
@@ -46,7 +52,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
4652
This is the first release of this project, based on https://chromium.googlesource.com/external/gyp
4753
with changes made over the years in Node.js and node-gyp.
4854

49-
[Unreleased]: https://github.com/nodejs/gyp-next/compare/v0.5.0...HEAD
55+
[Unreleased]: https://github.com/nodejs/gyp-next/compare/v0.6.0...HEAD
56+
[0.6.0]: https://github.com/nodejs/gyp-next/compare/v0.5.0...v0.6.0
5057
[0.5.0]: https://github.com/nodejs/gyp-next/compare/v0.4.0...v0.5.0
5158
[0.4.0]: https://github.com/nodejs/gyp-next/compare/v0.3.0...v0.4.0
5259
[0.3.0]: https://github.com/nodejs/gyp-next/compare/v0.2.1...v0.3.0

tools/gyp/pylib/gyp/generator/make.py

+10-10
Original file line numberDiff line numberDiff line change
@@ -1621,10 +1621,8 @@ def WriteTarget(
16211621
if any(dep.endswith(".so") or ".so." in dep for dep in deps):
16221622
# We want to get the literal string "$ORIGIN"
16231623
# into the link command, so we need lots of escaping.
1624-
ldflags.append(r"-Wl,-rpath=\$$ORIGIN/lib.%s/" % self.toolset)
1625-
ldflags.append(
1626-
r"-Wl,-rpath-link=\$(builddir)/lib.%s/" % self.toolset
1627-
)
1624+
ldflags.append(r"-Wl,-rpath=\$$ORIGIN/")
1625+
ldflags.append(r"-Wl,-rpath-link=\$(builddir)/")
16281626
library_dirs = config.get("library_dirs", [])
16291627
ldflags += [("-L%s" % library_dir) for library_dir in library_dirs]
16301628
self.WriteList(ldflags, "LDFLAGS_%s" % configname)
@@ -2172,14 +2170,16 @@ def ExpandInputRoot(self, template, expansion, dirname):
21722170

21732171
def _InstallableTargetInstallPath(self):
21742172
"""Returns the location of the final output for an installable target."""
2173+
# Functionality removed for all platforms to match Xcode and hoist
2174+
# shared libraries into PRODUCT_DIR for users:
21752175
# Xcode puts shared_library results into PRODUCT_DIR, and some gyp files
21762176
# rely on this. Emulate this behavior for mac.
2177-
if self.type == "shared_library" and (
2178-
self.flavor != "mac" or self.toolset != "target"
2179-
):
2180-
# Install all shared libs into a common directory (per toolset) for
2181-
# convenient access with LD_LIBRARY_PATH.
2182-
return "$(builddir)/lib.%s/%s" % (self.toolset, self.alias)
2177+
# if self.type == "shared_library" and (
2178+
# self.flavor != "mac" or self.toolset != "target"
2179+
# ):
2180+
# # Install all shared libs into a common directory (per toolset) for
2181+
# # convenient access with LD_LIBRARY_PATH.
2182+
# return "$(builddir)/lib.%s/%s" % (self.toolset, self.alias)
21832183
return "$(builddir)/" + self.alias
21842184

21852185

tools/gyp/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
setup(
1717
name="gyp-next",
18-
version="0.5.0",
18+
version="0.6.0",
1919
description="A fork of the GYP build system for use in the Node.js projects",
2020
long_description=long_description,
2121
long_description_content_type="text/markdown",

0 commit comments

Comments
 (0)