Skip to content

Commit bf028a6

Browse files
kapouerdanielleadams
authored andcommitted
src: lock-free init_process_flags
Fix #45152 PR-URL: #45221 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent bf8d48a commit bf028a6

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/node.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ void ResetSignalHandlers() {
445445
#endif // __POSIX__
446446
}
447447

448-
static std::atomic<uint64_t> init_process_flags = 0;
448+
static std::atomic<uint32_t> init_process_flags = 0;
449449

450450
static void PlatformInit(ProcessInitializationFlags::Flags flags) {
451451
// init_process_flags is accessed in ResetStdio(),

src/node.h

+2
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,8 @@ class MultiIsolatePlatform;
228228
class InitializationResultImpl;
229229

230230
namespace ProcessFlags {
231+
// TODO(addaleax): Switch to uint32_t to match std::atomic<uint32_t>
232+
// init_process_flags in node.cc
231233
enum Flags : uint64_t {
232234
kNoFlags = 0,
233235
// Enable stdio inheritance, which is disabled by default.

0 commit comments

Comments
 (0)