Skip to content

Commit c1aee02

Browse files
thefourtheyeMyles Borins
authored and
Myles Borins
committed
build: start comments at beginning of line
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: #9375 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4ccdbb2 commit c1aee02

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Makefile

+5-5
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,8 @@ test/addons/.buildstamp: config.gypi \
161161
deps/uv/include/*.h deps/v8/include/*.h \
162162
src/node.h src/node_buffer.h src/node_object_wrap.h src/node_version.h \
163163
test/addons/.docbuildstamp
164-
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
165-
# embedded addons have been generated from the documentation.
164+
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
165+
# embedded addons have been generated from the documentation.
166166
for dirname in test/addons/*/; do \
167167
echo "\nRunning addons test $$PWD/$$dirname" ; \
168168
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \
@@ -260,15 +260,15 @@ test-timers-clean:
260260

261261
ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
262262
test-v8: v8
263-
# note: performs full test unless QUICKCHECK is specified
263+
# note: performs full test unless QUICKCHECK is specified
264264
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
265265
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
266266
--no-presubmit \
267267
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
268268
$(TAP_V8)
269269

270270
test-v8-intl: v8
271-
# note: performs full test unless QUICKCHECK is specified
271+
# note: performs full test unless QUICKCHECK is specified
272272
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
273273
--mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \
274274
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \
@@ -281,7 +281,7 @@ test-v8-benchmarks: v8
281281
$(TAP_V8_BENCHMARKS)
282282

283283
test-v8-all: test-v8 test-v8-intl test-v8-benchmarks
284-
# runs all v8 tests
284+
# runs all v8 tests
285285
else
286286
test-v8 test-v8-intl test-v8-benchmarks test-v8-all:
287287
@echo "Testing v8 is not available through the source tarball."

0 commit comments

Comments
 (0)