Skip to content

Commit c1bcdbc

Browse files
authored
build: warn for gcc versions earlier than 10.1
Update the warning threshold for gcc to 10.1 starting from Node.js 20. Builds can still proceed with earlier versions of gcc, but are not guaranteed to work. PR-URL: #46806 Refs: #45892 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 78b911d commit c1bcdbc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

BUILDING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ Depending on the host platform, the selection of toolchains may vary.
152152

153153
| Operating System | Compiler Versions |
154154
| ---------------- | -------------------------------------------------------------- |
155-
| Linux | GCC >= 8.3 |
155+
| Linux | GCC >= 10.1 |
156156
| Windows | Visual Studio >= 2019 with the Windows 10 SDK on a 64-bit host |
157157
| macOS | Xcode >= 11 (Apple LLVM >= 11) |
158158

@@ -223,7 +223,7 @@ The Node.js project supports Python >= 3 for building and testing.
223223

224224
#### Unix prerequisites
225225

226-
* `gcc` and `g++` >= 8.3 or newer
226+
* `gcc` and `g++` >= 10.1 or newer
227227
* GNU Make 3.81 or newer
228228
* Python >=3.6 <=3.11 (see note above)
229229
* For test coverage, your Python installation must include pip.

configure.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1032,8 +1032,8 @@ def check_compiler(o):
10321032
('clang ' if is_clang else '', CXX, version_str))
10331033
if not ok:
10341034
warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX)
1035-
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (8, 3, 0):
1036-
warn('C++ compiler (CXX=%s, %s) too old, need g++ 8.3.0 or clang++ 8.0.0' %
1035+
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (10, 1, 0):
1036+
warn('C++ compiler (CXX=%s, %s) too old, need g++ 10.1.0 or clang++ 8.0.0' %
10371037
(CXX, version_str))
10381038

10391039
ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')

0 commit comments

Comments
 (0)