test: don't hard code deprecation count

PR-URL: #7927
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: princejwesley

test/parallel/test-crypto-deprecated.js

@@ -9,19 +9,19 @@ if (!common.hasCrypto) {
 const crypto = require('crypto');
 const tls = require('tls');
 
+const expected = [
+  'crypto.Credentials is deprecated. Use tls.SecureContext instead.',
+  'crypto.createCredentials is deprecated. Use tls.createSecureContext instead.'
+];
+
 process.on('warning', common.mustCall((warning) => {
   assert.strictEqual(warning.name, 'DeprecationWarning');
   assert.notStrictEqual(expected.indexOf(warning.message), -1,
                         `unexpected error message: "${warning.message}"`);
   // Remove a warning message after it is seen so that we guarantee that we get
   // each message only once.
   expected.splice(expected.indexOf(warning.message), 1);
-}, 2));
-
-var expected = [
-  'crypto.Credentials is deprecated. Use tls.SecureContext instead.',
-  'crypto.createCredentials is deprecated. Use tls.createSecureContext instead.'
-];
+}, expected.length));
 
 // Accessing the deprecated function is enough to trigger the warning event.
 // It does not need to be called. So the assert serves the purpose of both