Skip to content

Commit c55f661

Browse files
committed
tools: disable x86 safe exception handlers in V8
PR-URL: #35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 6cfba9f commit c55f661

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

tools/v8_gypfiles/toolchain.gypi

+8
Original file line numberDiff line numberDiff line change
@@ -1362,5 +1362,13 @@
13621362
4724, # https://crbug.com/v8/7771
13631363
4800, # Forcing value to bool.
13641364
],
1365+
# Relevant only for x86.
1366+
# Refs: https://github.com/nodejs/node/pull/25852
1367+
# Refs: https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers
1368+
'msvs_settings': {
1369+
'VCLinkerTool': {
1370+
'ImageHasSafeExceptionHandlers': 'false',
1371+
},
1372+
},
13651373
}, # target_defaults
13661374
}

0 commit comments

Comments
 (0)