Skip to content

Commit c598d98

Browse files
cjihrigtargos
authored andcommitted
report: use uv_pid_t instead of custom PID_TYPE
PR-URL: #25597 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
1 parent 213eddd commit c598d98

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/node_report.cc

+2-3
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,8 @@ std::string TriggerNodeReport(Isolate* isolate,
107107

108108
// Obtain the current time and the pid (platform dependent)
109109
TIME_TYPE tm_struct;
110-
PID_TYPE pid;
111110
LocalTime(&tm_struct);
112-
pid = uv_os_getpid();
111+
uv_pid_t pid = uv_os_getpid();
113112
// Determine the required report filename. In order of priority:
114113
// 1) supplied on API 2) configured on startup 3) default generated
115114
if (!name.empty()) {
@@ -224,7 +223,7 @@ static void WriteNodeReport(Isolate* isolate,
224223
Local<String> stackstr,
225224
TIME_TYPE* tm_struct) {
226225
std::ostringstream buf;
227-
PID_TYPE pid = uv_os_getpid();
226+
uv_pid_t pid = uv_os_getpid();
228227

229228
// Save formatting for output stream.
230229
std::ios old_state(nullptr);

src/node_report.h

-2
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,9 @@ namespace report {
3232

3333
#ifdef _WIN32
3434
typedef SYSTEMTIME TIME_TYPE;
35-
typedef DWORD PID_TYPE;
3635
#define PATHSEP "\\"
3736
#else // UNIX, OSX
3837
typedef struct tm TIME_TYPE;
39-
typedef pid_t PID_TYPE;
4038
#define PATHSEP "/"
4139
#endif
4240

0 commit comments

Comments
 (0)