Skip to content

Commit c632247

Browse files
tniessenjuanarbol
authored andcommitted
tls: remove SecureContext setFreeListLength
This function was introduced in 2684c90 as an internal helper function. The C++ implementation became a no-op in a57e2f2 when building against OpenSSL 1.1.0 (instead of OpenSSL 1.0.2), and eventually became a no-op in all supported OpenSSL versions in 970ce14. Finally, eb20447 removed the only call site of setFreeListLength (which was already a no-op at that point). Refs: #1529 Refs: #10859 Refs: #19794 Refs: #38116 PR-URL: #44300 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 833fdf0 commit c632247

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

src/crypto/crypto_context.cc

-5
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,6 @@ Local<FunctionTemplate> SecureContext::GetConstructorTemplate(
283283
env->SetProtoMethod(tmpl, "close", Close);
284284
env->SetProtoMethod(tmpl, "loadPKCS12", LoadPKCS12);
285285
env->SetProtoMethod(tmpl, "setTicketKeys", SetTicketKeys);
286-
env->SetProtoMethod(tmpl, "setFreeListLength", SetFreeListLength);
287286
env->SetProtoMethod(tmpl, "enableTicketKeyCallback",
288287
EnableTicketKeyCallback);
289288

@@ -363,7 +362,6 @@ void SecureContext::RegisterExternalReferences(
363362
registry->Register(Close);
364363
registry->Register(LoadPKCS12);
365364
registry->Register(SetTicketKeys);
366-
registry->Register(SetFreeListLength);
367365
registry->Register(EnableTicketKeyCallback);
368366
registry->Register(GetTicketKeys);
369367
registry->Register(GetCertificate<true>);
@@ -1119,9 +1117,6 @@ void SecureContext::SetTicketKeys(const FunctionCallbackInfo<Value>& args) {
11191117
#endif // !def(OPENSSL_NO_TLSEXT) && def(SSL_CTX_get_tlsext_ticket_keys)
11201118
}
11211119

1122-
void SecureContext::SetFreeListLength(const FunctionCallbackInfo<Value>& args) {
1123-
}
1124-
11251120
// Currently, EnableTicketKeyCallback and TicketKeyCallback are only present for
11261121
// the regression test in test/parallel/test-https-resume-after-renew.js.
11271122
void SecureContext::EnableTicketKeyCallback(

src/crypto/crypto_context.h

-2
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,6 @@ class SecureContext final : public BaseObject {
100100
#endif // !OPENSSL_NO_ENGINE
101101
static void GetTicketKeys(const v8::FunctionCallbackInfo<v8::Value>& args);
102102
static void SetTicketKeys(const v8::FunctionCallbackInfo<v8::Value>& args);
103-
static void SetFreeListLength(
104-
const v8::FunctionCallbackInfo<v8::Value>& args);
105103
static void EnableTicketKeyCallback(
106104
const v8::FunctionCallbackInfo<v8::Value>& args);
107105
static void CtxGetter(const v8::FunctionCallbackInfo<v8::Value>& info);

0 commit comments

Comments
 (0)