Skip to content

Commit c72c4b0

Browse files
tomgcoaddaleax
authored andcommitted
src: allow --perf-prof-unwinding-info in NODE_OPTIONS
PR-URL: #25565 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent e6a2548 commit c72c4b0

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

doc/api/cli.md

+1
Original file line numberDiff line numberDiff line change
@@ -714,6 +714,7 @@ V8 options that are allowed are:
714714
- `--perf-basic-prof`
715715
- `--perf-basic-prof-only-functions`
716716
- `--perf-prof`
717+
- `--perf-prof-unwinding-info`
717718
- `--stack-trace-limit`
718719

719720
### `NODE_PATH=path[:…]`

src/node_options.cc

+4
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser() {
304304
V8Option{},
305305
kAllowedInEnvironment);
306306
AddOption("--perf-prof", "", V8Option{}, kAllowedInEnvironment);
307+
AddOption("--perf-prof-unwinding-info",
308+
"",
309+
V8Option{},
310+
kAllowedInEnvironment);
307311
AddOption("--stack-trace-limit", "", V8Option{}, kAllowedInEnvironment);
308312

309313
#ifdef NODE_REPORT

test/parallel/test-cli-node-options.js

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ if (!common.isWindows) {
4444
if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {
4545
// PerfJitLogger is only implemented in Linux.
4646
expect('--perf-prof', 'B\n');
47+
expect('--perf-prof-unwinding-info', 'B\n');
4748
}
4849

4950
if (common.hasCrypto) {

0 commit comments

Comments
 (0)