zlib: fix use after null when calling .close

lightsofapollo · addaleax · commit c7fef3d3b876 · 2016-04-19T08:46:54.000+02:00
An internal zlib error may cause _handle to be set to null. Close now will check if there is a _handle prior to calling .close on it. PR-URL: #5982 Fixes: #6034 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -474,7 +474,10 @@ function _close(engine, callback) {
 
   engine._closed = true;
 
-  engine._handle.close();
+  // Caller may invoke .close after a zlib error (which will null _handle).
+  if (engine._handle) {
+    engine._handle.close();
+  }
 }
 
 function emitCloseNT(self) {

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,10 @@ function _close(engine, callback) {`
`474`	`474`
`475`	`475`	`engine._closed = true;`
`476`	`476`
`477`		`- engine._handle.close();`
	`477`	`+ // Caller may invoke .close after a zlib error (which will null _handle).`
	`478`	`+ if (engine._handle) {`
	`479`	`+ engine._handle.close();`
	`480`	`+ }`
`478`	`481`	`}`
`479`	`482`
`480`	`483`	`function emitCloseNT(self) {`