Skip to content

Commit c84d802

Browse files
bl-ueBethGriggs
authored andcommitted
worker: fix process.env var empty key access
PR-URL: #32921 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent a534d82 commit c84d802

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_env_var.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ void MapKVStore::Set(Isolate* isolate, Local<String> key, Local<String> value) {
227227
Mutex::ScopedLock lock(mutex_);
228228
Utf8Value key_str(isolate, key);
229229
Utf8Value value_str(isolate, value);
230-
if (*key_str != nullptr && *value_str != nullptr) {
230+
if (*key_str != nullptr && key_str.length() > 0 && *value_str != nullptr) {
231231
map_[std::string(*key_str, key_str.length())] =
232232
std::string(*value_str, value_str.length());
233233
}

0 commit comments

Comments
 (0)