Skip to content

Commit ca5ebcf

Browse files
addaleaxBethGriggs
authored andcommitted
tools: fix mkcodecache when run with ASAN
Fixes: #32835 PR-URL: #32850 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 3086813 commit ca5ebcf

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tools/code_cache/mkcodecache.cc

+3-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ int main(int argc, char* argv[]) {
4949

5050
// Create a new Isolate and make it the current one.
5151
Isolate::CreateParams create_params;
52-
create_params.array_buffer_allocator =
53-
ArrayBuffer::Allocator::NewDefaultAllocator();
52+
create_params.array_buffer_allocator_shared.reset(
53+
ArrayBuffer::Allocator::NewDefaultAllocator());
5454
Isolate* isolate = Isolate::New(create_params);
5555
{
5656
Isolate::Scope isolate_scope(isolate);
@@ -65,6 +65,7 @@ int main(int argc, char* argv[]) {
6565
out << cache;
6666
out.close();
6767
}
68+
isolate->Dispose();
6869

6970
v8::V8::ShutdownPlatform();
7071
return 0;

0 commit comments

Comments
 (0)