Skip to content

Commit cbfc980

Browse files
luketahertargos
authored andcommitted
perf_hooks: add missing type argument to getEntriesByName
Fixes: #54766 PR-URL: #54767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent bebc95e commit cbfc980

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

lib/internal/perf/performance.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,16 @@ class Performance extends EventTarget {
9797
return filterBufferMapByNameAndType();
9898
}
9999

100-
getEntriesByName(name) {
100+
getEntriesByName(name, type = undefined) {
101101
validateInternalField(this, kPerformanceBrand, 'Performance');
102102
if (arguments.length === 0) {
103103
throw new ERR_MISSING_ARGS('name');
104104
}
105105
name = `${name}`;
106-
return filterBufferMapByNameAndType(name, undefined);
106+
if (type !== undefined) {
107+
type = `${type}`;
108+
}
109+
return filterBufferMapByNameAndType(name, type);
107110
}
108111

109112
getEntriesByType(type) {

test/parallel/test-performance-timeline.mjs

+6
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@ await setTimeout(50);
3333
performance.measure('a', 'one');
3434
const entriesByName = performance.getEntriesByName('a');
3535
assert.deepStrictEqual(entriesByName.map((x) => x.entryType), ['measure', 'mark', 'measure', 'mark']);
36+
const marksByName = performance.getEntriesByName('a', 'mark');
37+
assert.deepStrictEqual(marksByName.map((x) => x.entryType), ['mark', 'mark']);
38+
const measuresByName = performance.getEntriesByName('a', 'measure');
39+
assert.deepStrictEqual(measuresByName.map((x) => x.entryType), ['measure', 'measure']);
40+
const invalidTypeEntriesByName = performance.getEntriesByName('a', null);
41+
assert.strictEqual(invalidTypeEntriesByName.length, 0);
3642

3743
// getEntriesBy[Name|Type](undefined)
3844
performance.mark(undefined);

0 commit comments

Comments
 (0)