Skip to content

Commit cc90bbd

Browse files
Trottaddaleax
authored andcommitted
test: fix flaky inspector-stop-profile-after-done
Use common.platformTimeout() to give longer durations to Raspberry Pi devices to make test more reliable. PR-URL: #18126 Fixes: #16772 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 77154cd commit cc90bbd

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

test/sequential/sequential.status

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ test-inspector-debug-end : PASS, FLAKY
1313
test-inspector-async-hook-setup-at-signal: PASS, FLAKY
1414
test-http2-ping-flood : PASS, FLAKY
1515
test-http2-settings-flood : PASS, FLAKY
16-
test-inspector-stop-profile-after-done: PASS, FLAKY
1716

1817
[$system==linux]
1918

test/sequential/test-inspector-stop-profile-after-done.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,18 @@ async function runTests() {
1212
console.log(new Object());
1313
if (c++ === 10)
1414
clearInterval(interval);
15-
}, 10);`);
15+
}, ${common.platformTimeout(30)});`);
1616
const session = await child.connectInspectorSession();
1717

1818
session.send([
19-
{ 'method': 'Profiler.setSamplingInterval', 'params': { 'interval': 100 } },
20-
{ 'method': 'Profiler.enable' },
21-
{ 'method': 'Runtime.runIfWaitingForDebugger' },
22-
{ 'method': 'Profiler.start' }]);
19+
{ method: 'Profiler.setSamplingInterval',
20+
params: { interval: common.platformTimeout(300) } },
21+
{ method: 'Profiler.enable' },
22+
{ method: 'Runtime.runIfWaitingForDebugger' },
23+
{ method: 'Profiler.start' }]);
2324
while (await child.nextStderrString() !==
2425
'Waiting for the debugger to disconnect...');
25-
await session.send({ 'method': 'Profiler.stop' });
26+
await session.send({ method: 'Profiler.stop' });
2627
session.disconnect();
2728
assert.strictEqual(0, (await child.expectShutdown()).exitCode);
2829
}

0 commit comments

Comments
 (0)