Skip to content

Commit ccca11d

Browse files
seishunMylesBorins
authored andcommitted
build,win: set /MP separately in Debug and Release
Setting /MP globally causes it to appear twice in the command line due to a GYP bug, which causes the project to be rebuilt unconditionally due to an msbuild bug. PR-URL: #16415 Fixes: #16367 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2b1042b commit ccca11d

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

common.gypi

+4-3
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@
112112
'BasicRuntimeChecks': 3, # /RTC1
113113
'AdditionalOptions': [
114114
'/bigobj', # prevent error C1128 in VS2015
115+
'/MP', # compile across multiple CPUs
115116
],
116117
},
117118
'VCLinkerTool': {
@@ -167,6 +168,9 @@
167168
'EnableFunctionLevelLinking': 'true',
168169
'EnableIntrinsicFunctions': 'true',
169170
'RuntimeTypeInfo': 'false',
171+
'AdditionalOptions': [
172+
'/MP', # compile across multiple CPUs
173+
],
170174
},
171175
'VCLibrarianTool': {
172176
'AdditionalOptions': [
@@ -199,9 +203,6 @@
199203
# and their sheer number drowns out other, more legitimate warnings.
200204
'DisableSpecificWarnings': ['4267'],
201205
'WarnAsError': 'false',
202-
'AdditionalOptions': [
203-
'/MP', # compile across multiple CPUs
204-
],
205206
},
206207
'VCLibrarianTool': {
207208
},

0 commit comments

Comments
 (0)