Skip to content

Commit cd1aa2b

Browse files
dominikeinkemmerrvagg
authored andcommitted
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js PR-URL: #24616 Refs: nodejsjp#1 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 82ef618 commit cd1aa2b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/parallel/test-http2-binding.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -233,16 +233,16 @@ const defaultSettings = {
233233

234234
for (const name of Object.keys(constants)) {
235235
if (name.startsWith('HTTP_STATUS_')) {
236-
assert.strictEqual(expectedStatusCodes[name], constants[name],
236+
assert.strictEqual(constants[name], expectedStatusCodes[name],
237237
`Expected status code match for ${name}`);
238238
} else if (name.startsWith('HTTP2_HEADER_')) {
239-
assert.strictEqual(expectedHeaderNames[name], constants[name],
239+
assert.strictEqual(constants[name], expectedHeaderNames[name],
240240
`Expected header name match for ${name}`);
241241
} else if (name.startsWith('NGHTTP2_')) {
242-
assert.strictEqual(expectedNGConstants[name], constants[name],
242+
assert.strictEqual(constants[name], expectedNGConstants[name],
243243
`Expected ng constant match for ${name}`);
244244
} else if (name.startsWith('DEFAULT_SETTINGS_')) {
245-
assert.strictEqual(defaultSettings[name], constants[name],
245+
assert.strictEqual(constants[name], defaultSettings[name],
246246
`Expected default setting match for ${name}`);
247247
}
248248
}

0 commit comments

Comments
 (0)