Skip to content

Commit ce28caf

Browse files
committed
report: represent numbers as numbers
Do not stringify numbers and boolean values when writing JSON. PR-URL: #25651 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 1dfdbc6 commit ce28caf

File tree

3 files changed

+124
-190
lines changed

3 files changed

+124
-190
lines changed

doc/api/report.md

+71-71
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ is provided below for reference.
2727
"filename": "report.20181221.005011.8974.001.json",
2828
"dumpEventTime": "2018-12-21T00:50:11Z",
2929
"dumpEventTimeStamp": "1545371411331",
30-
"processId": "8974",
30+
"processId": 8974,
3131
"commandLine": [
3232
"/home/nodeuser/project/node/out/Release/node",
3333
"--experimental-report",
@@ -81,133 +81,133 @@ is provided below for reference.
8181
" [pc=0x1930cae] [/home/nodeuser/project/node/out/Release/node]"
8282
],
8383
"javascriptHeap": {
84-
"totalMemory": "6127616",
85-
"totalCommittedMemory": "4357352",
86-
"usedMemory": "3221136",
87-
"availableMemory": "1521370240",
88-
"memoryLimit": "1526909922",
84+
"totalMemory": 6127616,
85+
"totalCommittedMemory": 4357352,
86+
"usedMemory": 3221136,
87+
"availableMemory": 1521370240,
88+
"memoryLimit": 1526909922,
8989
"heapSpaces": {
9090
"read_only_space": {
91-
"memorySize": "524288",
92-
"committedMemory": "39208",
93-
"capacity": "515584",
94-
"used": "30504",
95-
"available": "485080"
91+
"memorySize": 524288,
92+
"committedMemory": 39208,
93+
"capacity": 515584,
94+
"used": 30504,
95+
"available": 485080
9696
},
9797
"new_space": {
98-
"memorySize": "2097152",
99-
"committedMemory": "2019312",
100-
"capacity": "1031168",
101-
"used": "985496",
102-
"available": "45672"
98+
"memorySize": 2097152,
99+
"committedMemory": 2019312,
100+
"capacity": 1031168,
101+
"used": 985496,
102+
"available": 45672
103103
},
104104
"old_space": {
105-
"memorySize": "2273280",
106-
"committedMemory": "1769008",
107-
"capacity": "1974640",
108-
"used": "1725488",
109-
"available": "249152"
105+
"memorySize": 2273280,
106+
"committedMemory": 1769008,
107+
"capacity": 1974640,
108+
"used": 1725488,
109+
"available": 249152
110110
},
111111
"code_space": {
112-
"memorySize": "696320",
113-
"committedMemory": "184896",
114-
"capacity": "152128",
115-
"used": "152128",
116-
"available": "0"
112+
"memorySize": 696320,
113+
"committedMemory": 184896,
114+
"capacity": 152128,
115+
"used": 152128,
116+
"available": 0
117117
},
118118
"map_space": {
119-
"memorySize": "536576",
120-
"committedMemory": "344928",
121-
"capacity": "327520",
122-
"used": "327520",
123-
"available": "0"
119+
"memorySize": 536576,
120+
"committedMemory": 344928,
121+
"capacity": 327520,
122+
"used": 327520,
123+
"available": 0
124124
},
125125
"large_object_space": {
126-
"memorySize": "0",
127-
"committedMemory": "0",
128-
"capacity": "1520590336",
129-
"used": "0",
130-
"available": "1520590336"
126+
"memorySize": 0,
127+
"committedMemory": 0,
128+
"capacity": 1520590336,
129+
"used": 0,
130+
"available": 1520590336
131131
},
132132
"new_large_object_space": {
133-
"memorySize": "0",
134-
"committedMemory": "0",
135-
"capacity": "0",
136-
"used": "0",
137-
"available": "0"
133+
"memorySize": 0,
134+
"committedMemory": 0,
135+
"capacity": 0,
136+
"used": 0,
137+
"available": 0
138138
}
139139
}
140140
},
141141
"resourceUsage": {
142-
"userCpuSeconds": "0.069595",
143-
"kernelCpuSeconds": "0.019163",
144-
"cpuConsumptionPercent": "0.000000",
145-
"maxRss": "18079744",
142+
"userCpuSeconds": 0.069595,
143+
"kernelCpuSeconds": 0.019163,
144+
"cpuConsumptionPercent": 0.000000,
145+
"maxRss": 18079744,
146146
"pageFaults": {
147-
"IORequired": "0",
148-
"IONotRequired": "4610"
147+
"IORequired": 0,
148+
"IONotRequired": 4610
149149
},
150150
"fsActivity": {
151-
"reads": "0",
152-
"writes": "0"
151+
"reads": 0,
152+
"writes": 0
153153
}
154154
},
155155
"uvthreadResourceUsage": {
156-
"userCpuSeconds": "0.068457",
157-
"kernelCpuSeconds": "0.019127",
158-
"cpuConsumptionPercent": "0.000000",
156+
"userCpuSeconds": 0.068457,
157+
"kernelCpuSeconds": 0.019127,
158+
"cpuConsumptionPercent": 0.000000,
159159
"fsActivity": {
160-
"reads": "0",
161-
"writes": "0"
160+
"reads": 0,
161+
"writes": 0
162162
}
163163
},
164164
"libuv": [
165165
{
166166
"type": "async",
167-
"is_active": "1",
168-
"is_referenced": "0",
167+
"is_active": true,
168+
"is_referenced": false,
169169
"address": "68090592",
170170
"details": ""
171171
},
172172
{
173173
"type": "timer",
174-
"is_active": "0",
175-
"is_referenced": "0",
174+
"is_active": false,
175+
"is_referenced": false,
176176
"address": "140723513949920",
177177
"details": "repeat: 0, timeout expired: 18075165916 ms ago"
178178
},
179179
{
180180
"type": "check",
181-
"is_active": "1",
182-
"is_referenced": "0",
181+
"is_active": true,
182+
"is_referenced": false,
183183
"address": "140723513950072",
184184
"details": ""
185185
},
186186
{
187187
"type": "idle",
188-
"is_active": "0",
189-
"is_referenced": "1",
188+
"is_active": false,
189+
"is_referenced": true,
190190
"address": "140723513950192",
191191
"details": ""
192192
},
193193
{
194194
"type": "prepare",
195-
"is_active": "0",
196-
"is_referenced": "0",
195+
"is_active": false,
196+
"is_referenced": false,
197197
"address": "140723513950312",
198198
"details": ""
199199
},
200200
{
201201
"type": "check",
202-
"is_active": "0",
203-
"is_referenced": "0",
202+
"is_active": false,
203+
"is_referenced": false,
204204
"address": "140723513950432",
205205
"details": ""
206206
},
207207
{
208208
"type": "async",
209-
"is_active": "1",
210-
"is_referenced": "0",
209+
"is_active": true,
210+
"is_referenced": false,
211211
"address": "39353856",
212212
"details": ""
213213
}
@@ -264,15 +264,15 @@ is provided below for reference.
264264
},
265265
"max_locked_memory_bytes": {
266266
"soft": "unlimited",
267-
"hard": "65536"
267+
"hard": 65536
268268
},
269269
"max_memory_size_kbytes": {
270270
"soft": "unlimited",
271271
"hard": "unlimited"
272272
},
273273
"open_files": {
274274
"soft": "unlimited",
275-
"hard": "4096"
275+
"hard": 4096
276276
},
277277
"stack_size_bytes": {
278278
"soft": "unlimited",
@@ -284,7 +284,7 @@ is provided below for reference.
284284
},
285285
"max_user_processes": {
286286
"soft": "unlimited",
287-
"hard": "4127290"
287+
"hard": 4127290
288288
},
289289
"virtual_memory_kbytes": {
290290
"soft": "unlimited",

0 commit comments

Comments
 (0)