Skip to content

Commit d123f94

Browse files
cjihrigtargos
authored andcommitted
test: remove extraneous report validation argument
The second argument passed to validate() and validateContent() is not used for anything. PR-URL: #25986 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 29c195e commit d123f94

8 files changed

+8
-30
lines changed

test/node-report/test-api-getreport.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,5 @@ if (process.argv[2] === 'child') {
2121
' experimental feature. This feature could change at any time'), std_msg);
2222
const reportFiles = helper.findReports(child.pid, tmpdir.path);
2323
assert.deepStrictEqual(reportFiles, [], report_msg);
24-
helper.validateContent(child.stdout, { pid: child.pid,
25-
commandline: process.execPath +
26-
' ' + args.join(' ')
27-
});
24+
helper.validateContent(child.stdout);
2825
}

test/node-report/test-api-nohooks.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ if (process.argv[2] === 'child') {
2323
const reports = helper.findReports(child.pid, tmpdir.path);
2424
assert.strictEqual(reports.length, 1, report_msg);
2525
const report = reports[0];
26-
helper.validate(report, { pid: child.pid,
27-
commandline: child.spawnargs.join(' ')
28-
});
26+
helper.validate(report);
2927
}));
3028
}

test/node-report/test-api-pass-error.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ if (process.argv[2] === 'child') {
2525
const reports = helper.findReports(child.pid, tmpdir.path);
2626
assert.strictEqual(reports.length, 1, report_msg);
2727
const report = reports[0];
28-
helper.validate(report, { pid: child.pid,
29-
commandline: child.spawnargs.join(' '),
30-
expectedException: 'Testing error handling',
31-
});
28+
helper.validate(report);
3229
}));
3330
}

test/node-report/test-api-uvhandles.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@ if (process.argv[2] === 'child') {
126126
assert.deepStrictEqual(udp, 1, udp_msg);
127127

128128
// Common report tests.
129-
helper.validateContent(stdout, { pid: child.pid,
130-
commandline: child.spawnargs.join(' ')
131-
});
129+
helper.validateContent(stdout);
132130
}));
133131
}

test/node-report/test-api.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ if (process.argv[2] === 'child') {
2222
const reports = helper.findReports(child.pid, tmpdir.path);
2323
assert.strictEqual(reports.length, 1, report_msg);
2424
const report = reports[0];
25-
helper.validate(report, { pid: child.pid,
26-
commandline: child.spawnargs.join(' ')
27-
});
25+
helper.validate(report);
2826
}));
2927
}

test/node-report/test-exception.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ if (process.argv[2] === 'child') {
3737
const reports = helper.findReports(child.pid, tmpdir.path);
3838
assert.strictEqual(reports.length, 1, report_msg);
3939
const report = reports[0];
40-
helper.validate(report, { pid: child.pid,
41-
commandline: child.spawnargs.join(' ')
42-
});
40+
helper.validate(report);
4341
}));
4442
}

test/node-report/test-fatal-error.js

+1-7
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@ if (process.argv[2] === 'child') {
3333
const reports = helper.findReports(child.pid, tmpdir.path);
3434
assert.strictEqual(reports.length, 1);
3535
const report = reports[0];
36-
const options = { pid: child.pid };
37-
// Node.js currently overwrites the command line on AIX
38-
// https://github.com/nodejs/node/issues/10607
39-
if (!(common.isAIX || common.isSunOS)) {
40-
options.commandline = child.spawnargs.join(' ');
41-
}
42-
helper.validate(report, options);
36+
helper.validate(report);
4337
}));
4438
}

test/node-report/test-signal.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ if (process.argv[2] === 'child') {
7373
const reports = helper.findReports(child.pid, tmpdir.path);
7474
assert.deepStrictEqual(reports.length, 1, report_msg);
7575
const report = reports[0];
76-
helper.validate(report, { pid: child.pid,
77-
commandline: child.spawnargs.join(' ')
78-
});
76+
helper.validate(report);
7977
}));
8078
}

0 commit comments

Comments
 (0)