Skip to content

Commit d197105

Browse files
brieteaddaleax
authored andcommitted
os: move process.binding('os') to internalBinding
PR-URL: #25087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: #25446
1 parent 445ba9f commit d197105

File tree

5 files changed

+9
-3
lines changed

5 files changed

+9
-3
lines changed

lib/internal/bootstrap/loaders.js

+1
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ const internalBindingWhitelist = [
9393
'inspector',
9494
'js_stream',
9595
'natives',
96+
'os',
9697
'pipe_wrap',
9798
'process_wrap',
9899
'signal_wrap',

lib/os.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const {
4444
getUptime,
4545
isBigEndian,
4646
setPriority: _setPriority
47-
} = process.binding('os');
47+
} = internalBinding('os');
4848

4949
function getCheckedFunction(fn) {
5050
return function checkError(...args) {

src/node_os.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -467,4 +467,4 @@ void Initialize(Local<Object> target,
467467
} // namespace os
468468
} // namespace node
469469

470-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(os, node::os::Initialize)
470+
NODE_MODULE_CONTEXT_AWARE_INTERNAL(os, node::os::Initialize)

test/parallel/test-os-checked-function.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
'use strict';
2+
// Flags: --expose_internals
3+
4+
const { internalBinding } = require('internal/test/binding');
5+
26
// Monkey patch the os binding before requiring any other modules, including
37
// common, which requires the os module.
4-
process.binding('os').getHomeDirectory = function(ctx) {
8+
internalBinding('os').getHomeDirectory = function(ctx) {
59
ctx.syscall = 'foo';
610
ctx.code = 'bar';
711
ctx.message = 'baz';

test/parallel/test-process-binding-internalbinding-whitelist.js

+1
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,4 @@ assert(process.binding('js_stream'));
1818
assert(process.binding('buffer'));
1919
assert(process.binding('fs'));
2020
assert(process.binding('inspector'));
21+
assert(process.binding('os'));

0 commit comments

Comments
 (0)