Skip to content

Commit d311916

Browse files
joyeecheungtargos
authored andcommitted
test: fix calculations in test-worker-resource-limits
The heap size limit should be the sum of old generation and young generation size limits, and does not solely depend on the limit of the old generation. PR-URL: #42702 Refs: #35711 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 6bd2420 commit d311916

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/parallel/test-worker-resource-limits.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ if (!process.env.HAS_STARTED_WORKER) {
3535
assert.deepStrictEqual(resourceLimits, testResourceLimits);
3636
const array = [];
3737
while (true) {
38-
// Leave 10% wiggle room here, and 20% on debug builds.
39-
const wiggleRoom = common.buildType === 'Release' ? 1.1 : 1.2;
4038
const usedMB = v8.getHeapStatistics().used_heap_size / 1024 / 1024;
41-
assert(usedMB < resourceLimits.maxOldGenerationSizeMb * wiggleRoom);
39+
const maxReservedSize = resourceLimits.maxOldGenerationSizeMb +
40+
resourceLimits.maxYoungGenerationSizeMb;
41+
assert(usedMB < maxReservedSize);
4242

4343
let seenSpaces = 0;
4444
for (const { space_name, space_size } of v8.getHeapSpaceStatistics()) {

0 commit comments

Comments
 (0)