Skip to content

Commit d529a46

Browse files
jalafeljasnell
authored andcommittedOct 14, 2016
doc: explains why Reviewed-By is added in PRs
Adds verbose reasons to the documentation on why the Reviewed-By metadata on a pull request is important. This was loosely mentioned as an issue in the referenced issue below, and answered by @addaleax. Ref: #8893 PR-URL: #9044 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 482995e commit d529a46

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed
 

‎COLLABORATOR_GUIDE.md

+2
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ information regarding the change process:
101101

102102
- A `Reviewed-By: Name <email>` line for yourself and any
103103
other Collaborators who have reviewed the change.
104+
- Useful for @mentions / contact list if something goes wrong in the PR.
105+
- Protects against the assumption that GitHub will be around forever.
104106
- A `PR-URL:` line that references the *full* GitHub URL of the original
105107
pull request being merged so it's easy to trace a commit back to the
106108
conversation that led up to that change.

0 commit comments

Comments
 (0)